Skip to content

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented May 8, 2025

Updating docs before the release

@ihrpr ihrpr marked this pull request as ready for review May 8, 2025 11:31
Copy link
Member

@jerome3o-anthropic jerome3o-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

bhosmer-ant
bhosmer-ant previously approved these changes May 8, 2025
Copy link
Contributor

@bhosmer-ant bhosmer-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple v minor ideas inline but feel free to ignore

README.md Outdated

### Mounting to an Existing ASGI Server

> **Note**: SSE transport is being superseded by streamable HTTP transport. Consider using streamable HTTP for production deployments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw the wording here is slightly different from the prior note

README.md Outdated
asyncio.run(run())
```

Clients can also connect using streamable HTTP transport:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk does this deserve its own section header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "how should I decide what transport my client should use" noob question might come to mind here - if there's somewhere else in the docs where we cover this, it might be a nice thing to link to

Base automatically changed from ihrpr/shttp to main May 8, 2025 19:43
@ihrpr ihrpr dismissed stale reviews from bhosmer-ant and jerome3o-anthropic May 8, 2025 19:43

The base branch was changed.

@ihrpr ihrpr merged commit 72003d9 into main May 8, 2025
13 of 15 checks passed
@ihrpr ihrpr deleted the ihrpr/shttp-docs branch May 8, 2025 19:49
gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
…-deprecation-note

Add replacement warning about SSE to Streamable HTTP Transport in the User Guide
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants